MINOR: Move TerseFailure to server-common#21890
Open
m1a2st wants to merge 3 commits intoapache:trunkfrom
Open
Conversation
github-actions
bot
added
triage
chia7712
reviewed
Mar 30, 2026
| import com.fasterxml.jackson.dataformat.yaml.YAMLGenerator.Feature | ||
| import kafka.Kafka | ||
| import kafka.tools.{StorageTool, TerseFailure} | ||
| import kafka.tools.StorageTool |
Member
There was a problem hiding this comment.
would you mind optimizing the import order?
chia7712
reviewed
Mar 30, 2026
| */ | ||
| class TerseFailure(message: String, cause: Throwable) extends KafkaException(message, cause) { | ||
| def this(message: String) = this(message, null) | ||
| public class TerseFailure extends KafkaException { |
Member
There was a problem hiding this comment.
Since it is used by both core and shell, maybe the server module would be a better fit?
Collaborator
Author
There was a problem hiding this comment.
However, MetadataShell uses this exception, and the shell module does not depend on the server module.
github-actions
bot
added
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewite this class and move to server-common module
Reviewers: Chia-Ping Tsai chia7712@gmail.com